RFR: 1851: Fold CSR bot into PR bot [v3]

Zhao Song zsong at openjdk.org
Tue Mar 28 19:47:19 UTC 2023

On Tue, 28 Mar 2023 17:39:19 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> bots/pr/src/test/java/org/openjdk/skara/bots/pr/CSRBotTests.java line 94:
>>> 92:             TestBotRunner.runPeriodicItems(csrIssueBot);
>>> 93:             // The bot should have removed the CSR label
>>> 94:             assertFalse(pr.store().labelNames().contains("csr"));
>> At this point, the label is removed, but the PR body still doesn't have the checkbox checked. I think the logic for the checkbox and the label need to be unified and consistent.
> I think the checkbox should already be checked at that point.

Please see the latest commit. I have updated this test.


PR Review Comment: https://git.openjdk.org/skara/pull/1492#discussion_r1150978289

More information about the skara-dev mailing list