RFR: 1851: Fold CSR bot into PR bot [v3]
Zhao Song
zsong at openjdk.org
Tue Mar 28 22:27:01 UTC 2023
On Tue, 28 Mar 2023 22:15:03 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
>> Zhao Song has updated the pull request incrementally with four additional commits since the last revision:
>>
>> - fix a problem
>> - fix a problem
>> - renamed some classes
>> - improve PullRequestBotFactoryTest
>
> bots/pr/src/test/java/org/openjdk/skara/bots/pr/CSRCommandTests.java line 453:
>
>> 451:
>> 452: // The bot should reply with a message that there is already an approved CSR request
>> 453: // Now CheckWorkItem is responsible for updating CSR label, so before '/csr' is handled, csr label is added to this pr
>
> We should avoid comments that reference a change in the code. After this PR is integrated, it's no longer relevant that this functionality moved to CheckWorkItem.
Got it. Will change it
-------------
PR Review Comment: https://git.openjdk.org/skara/pull/1492#discussion_r1151209779
More information about the skara-dev
mailing list