RFR: 1859: Add "tags only" option to MirrorBot [v2]

Erik Helin ehelin at openjdk.org
Wed Mar 29 11:46:17 UTC 2023

On Tue, 28 Mar 2023 13:13:50 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Erik Helin has updated the pull request incrementally with one additional commit since the last revision:
>>   Reviewer feeback
> Could you expand the `MirrorBotFactory` test to verify the new configuration options? It's also worth pointing out that existing configurations will need to be updated when this change goes live.

@erikj79 thans, I added a bunch of tests in `MirrorBotFactoryTest.java`. As I wrote the tests I realized it was more natural to use a string value for the `"tags"` field, see the tests in the latest version for examples.

@zhaosongzs I think the latest version also resolves your comment, please have a look.


PR Comment: https://git.openjdk.org/skara/pull/1493#issuecomment-1488449252

More information about the skara-dev mailing list