RFR: 1856: Include a link to the webrev comment in the pull request's description

Zhao Song zsong at openjdk.org
Wed Mar 29 22:03:40 UTC 2023

On Wed, 29 Mar 2023 21:58:06 GMT, Zhao Song <zsong at openjdk.org> wrote:

> Some users complained about that GitHub often hide the webrev comment and it's hard for them to find webrev comment among hundreds of comments. 
> In this patch, the pr bot would add the link to webrev comment to the pr body.
> Originally, the comments from mlbridge bot would not trigger the update of the pr, now, when mlbridge bot **first** post the webrev comment, it will trigger the update of the pr.

bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckWorkItem.java line 100:

> 98:                                         .collect(Collectors.joining());
> 99:             commentString = commentString + comments.stream()
> 100:                     .filter(comment -> comment.author().username().equals("mlbridge[bot]"))

We also could compare `comment.author().id()` here, but I am not sure if it is a good idea to explicitly expose the id of mlbridge bot.


PR Review Comment: https://git.openjdk.org/skara/pull/1494#discussion_r1152525545

More information about the skara-dev mailing list