RFR: 1851: Fold CSR bot into PR bot [v5]

Erik Joelsson erikj at openjdk.org
Thu Mar 30 18:23:25 UTC 2023

On Tue, 28 Mar 2023 22:30:56 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> In this patch, the whole csr bot module is removed. 
>> Original CSRPullRequestBot is deleted. The functionality of this bot has been moved to `CheckRun`.
>> Original CSRIssueBot has been moved to pr bot module. PullRequestBotFactory would generate a CSRIssueBot for every configured Issue project.
> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>   improve some comments

Almost done now.

bots/pr/src/main/java/org/openjdk/skara/bots/pr/CSRIssueBot.java line 85:

> 83:     @Override
> 84:     public String name() {
> 85:         return PullRequestBotFactory.NAME;

The name of this `Bot` needs to be unique to avoid creating confusion with log messages. Perhaps add `-csr` as a suffix.

bots/pr/src/main/java/org/openjdk/skara/bots/pr/CSRIssueWorkItem.java line 112:

> 110:     @Override
> 111:     public String botName() {
> 112:         return "CSRIssueBot";

If you fix the `name()` of `CSRIssueBot`, you can reference that here instead.


PR Review: https://git.openjdk.org/skara/pull/1492#pullrequestreview-1365673849
PR Review Comment: https://git.openjdk.org/skara/pull/1492#discussion_r1153622239
PR Review Comment: https://git.openjdk.org/skara/pull/1492#discussion_r1153627012

More information about the skara-dev mailing list