RFR: 1859: Add "tags only" option to MirrorBot [v2]

Erik Joelsson erikj at openjdk.org
Thu Mar 30 18:47:23 UTC 2023


On Wed, 29 Mar 2023 16:04:19 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> Erik Helin has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Reviewer feeback
>
> bots/mirror/src/test/java/org/openjdk/skara/bots/mirror/MirrorBotFactoryTest.java line 234:
> 
>> 232:                           "to": "to4",
>> 233:                           "tags": "exclude"
>> 234:                         },
> 
> I am wondering what's the expected behavior for the mirror bot configured like this? Intuitively speaking, I think the bot should mirror every branch but excluding tags. But currently, the bot would not mirror anything. if i am wrong please correct me. Thank you!

I believe you are correct, this config will mirror nothing, but I agree that the expectation would be to mirror all branches but no tags.

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1493#discussion_r1153637628


More information about the skara-dev mailing list