RFR: 1856: Include a link to the webrev comment in the pull request's description

Zhao Song zsong at openjdk.org
Thu Mar 30 19:15:35 UTC 2023

On Thu, 30 Mar 2023 18:43:40 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckWorkItem.java line 100:
>>> 98:                                         .collect(Collectors.joining());
>>> 99:             commentString = commentString + comments.stream()
>>> 100:                     .filter(comment -> comment.author().username().equals("mlbridge[bot]"))
>> We also could compare `comment.author().id()` here, but I am not sure if it is a good idea to explicitly expose the id of mlbridge bot.
> The `commentString` looks like it's only containing comments from the currentUser (which is the bot user for the pr bot). I think we need to filter all comments again for the mlbridge user to find this comment.

Yes, commentString only containing comments from the currentUser. So I actually filter all comments again in line 99.


PR Review Comment: https://git.openjdk.org/skara/pull/1494#discussion_r1153675572

More information about the skara-dev mailing list