RFR: 1899: Stop notifiers when the PR bot fails to retrieve issue temporarily

Erik Joelsson erikj at openjdk.org
Thu May 4 21:02:51 UTC 2023

On Thu, 4 May 2023 17:54:15 GMT, Zhao Song <zsong at openjdk.org> wrote:

> A user reported that skara bot was editing the links in [JDK-8306027](https://bugs.openjdk.org/browse/JDK-8306027) and generated many mail spam.
> As Erik said, [JDK-8306781](https://bugs.openjdk.org/browse/JDK-8306781) is the CSR of JDK-8306027. JDK-8306781 was updated few hours ago and it triggered CSRIssueWorkItem to update the pull request(https://github.com/openjdk/jdk/pull/13661). However, when updating the pr, the bot failed to retrieve JDK-8306027 and printed "⚠️ Temporary failure when trying to retrieve information on issue 8306027" in the pr body. This update of PR body triggered PullRequestWorkItem in NotifyBot and make issueNotifier to update links to PR issues.
> To resolve this issue, I think we could stop the notifiers when the bot finds temporary issue failure.
> Once the temporary issue failure has been resolved, the pr body will be updated again and it will trigger the notifiers to work.

Seems reasonable. Thanks for figuring this out!


Marked as reviewed by erikj (Lead).

PR Review: https://git.openjdk.org/skara/pull/1512#pullrequestreview-1413917322

More information about the skara-dev mailing list