RFR: 1340: Correct email domain not always used when adding a contributor to a PR [v2]

Guoxiong Li gli at openjdk.org
Fri May 5 18:19:15 UTC 2023


On Fri, 5 May 2023 18:15:16 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> Now, the email domain for additional contributors is always the default "openjdk.org" domain because we hardcoded it.
>> 
>> To resolve this issue, we should use the domain in jcheck configuration file.
>
> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
> 
>   fix a problem

Looks good. 

> But it is curious that the building and testing of the Pre-submit tests succeeded.

But still strange.

-------------

Marked as reviewed by gli (Committer).

PR Review: https://git.openjdk.org/skara/pull/1513#pullrequestreview-1415246148


More information about the skara-dev mailing list