RFR: 1332: Skara sometimes fails to detect that a backport was clean

Erik Joelsson erikj at openjdk.org
Mon May 8 20:31:20 UTC 2023

On Mon, 8 May 2023 19:45:59 GMT, Zhao Song <zsong at openjdk.org> wrote:

> The pr bot sometimes fails to detect a backport is clean.
> This issue for GitHub part was resolved by Guoxiong Li in [SKARA-1406](https://bugs.openjdk.org/browse/SKARA-1406).
> This issue for GitLab part will be resolved in this patch.
> Investigated some GitLab MR examples, I found that although the GitLab UI shows there are diffs in some files, when the bot queries changes of the pr, GitLab would tell the bot there are no diffs in some files. 
> After reading the GitLab Api document, I found that we should set `access_raw_diffs` to `true` to get all the diffs.
> https://docs.gitlab.com/ee/api/merge_requests.html#get-single-merge-request-changes

Good investigation. This should get more diffs classified as clean. Reading the doc, there may still be limitations at play, and in the end we may end up having to perform the comparison with local repos, but this is definitely worth trying first.


Marked as reviewed by erikj (Lead).

PR Review: https://git.openjdk.org/skara/pull/1515#pullrequestreview-1417468726

More information about the skara-dev mailing list