RFR: 1907: PR should not be integrated with the temporary issue failure [v2]

Zhao Song zsong at openjdk.org
Wed May 10 23:33:53 UTC 2023

> In SKARA-1899, we stopped all notifiers if the bot found temporary issue failure because we think it's just temporary issue failure and once the failure got resolved, the notifiers will be triggered again. However, it will introduce a new problem. If the pr is integrated when the temporary issue failure is happening, the notifiers will not be trigger again because the pr bot will not update integrated pr body.
> Also, if the pr is integrated with the temporary issue failure, it would make the issue never get resolved.
> In this patch, the conditions for stopping notifiers have been tightened. Besides, the pr bot would not mark a pr as ready is the pr body contains `TEMPORARY_ISSUE_FAILURE_MARKER`

Zhao Song has updated the pull request incrementally with one additional commit since the last revision:



  - all: https://git.openjdk.org/skara/pull/1518/files
  - new: https://git.openjdk.org/skara/pull/1518/files/9d42fb7d..33232890

 - full: https://webrevs.openjdk.org/?repo=skara&pr=1518&range=01
 - incr: https://webrevs.openjdk.org/?repo=skara&pr=1518&range=00-01

  Stats: 4 lines in 1 file changed: 2 ins; 0 del; 2 mod
  Patch: https://git.openjdk.org/skara/pull/1518.diff
  Fetch: git fetch https://git.openjdk.org/skara.git pull/1518/head:pull/1518

PR: https://git.openjdk.org/skara/pull/1518

More information about the skara-dev mailing list