RFR: 1909: Empty GET calls should be left empty

Kevin Rushforth kcr at openjdk.org
Thu May 11 13:51:42 UTC 2023

On Thu, 11 May 2023 13:15:34 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> Over the last week, we have had issues with JBS returning weird errors seemingly randomly, which has caused a lot of problems with the bots. It turns out our hosting provider has become more stringent with handling http/2 requests and no longer likes GET requests with a request body. Skara currently always fills in the body of a request, regardless of type, with an empty JSON document '{}' when the body is empty. This seems to be faulty behavior and we should let empty GET calls be empty instead.
> I have been running staging with this patch over night and there were no errors.

Looks good.


Marked as reviewed by kcr (Reviewer).

PR Review: https://git.openjdk.org/skara/pull/1519#pullrequestreview-1422631309

More information about the skara-dev mailing list