Integrated: 1907: PR should not be integrated with the temporary issue failure

Zhao Song zsong at openjdk.org
Thu May 11 20:34:48 UTC 2023


On Wed, 10 May 2023 18:12:20 GMT, Zhao Song <zsong at openjdk.org> wrote:

> In SKARA-1899, we stopped all notifiers if the bot found temporary issue failure because we think it's just temporary issue failure and once the failure got resolved, the notifiers will be triggered again. However, it will introduce a new problem. If the pr is integrated when the temporary issue failure is happening, the notifiers will not be trigger again because the pr bot will not update integrated pr body.
> 
> Also, if the pr is integrated with the temporary issue failure, it would make the issue never get resolved.
> 
> In this patch, the conditions for stopping notifiers have been tightened. Besides, the pr bot would not mark a pr as ready is the pr body contains `TEMPORARY_ISSUE_FAILURE_MARKER`

This pull request has now been integrated.

Changeset: f4b77000
Author:    Zhao Song <zsong at openjdk.org>
URL:       https://git.openjdk.org/skara/commit/f4b7700009405aaf8c0d142cc3687f8c4fa95284
Stats:     5 lines in 2 files changed: 2 ins; 0 del; 3 mod

1907: PR should not be integrated with the temporary issue failure

Reviewed-by: erikj

-------------

PR: https://git.openjdk.org/skara/pull/1518


More information about the skara-dev mailing list