RFR: 1910: Basic support for Bitbucket as a Forge [v2]

[Erik Joelsson]

On Tue, 16 May 2023 18:57:12 GMT, Erik Helin <ehelin at openjdk.org> wrote:

>> Erik Joelsson has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comments
>
> forge/src/main/java/org/openjdk/skara/forge/bitbucket/BitbucketForgeFactory.java line 59:
> 
>> 57:             sshport = configuration.get("sshport").asInt();
>> 58:         }
>> 59:         if (credential != null) {
> 
> I would probably have used an `ssh` object in the config here, as in:
> 
> 
> if (configuration != null && configuration.contains("ssh")) {
>     var ssh = configuration.get("ssh");
>     var key = ssh.get("key").asString();
>     var port = ssh.contains("port") ? ssh.get("port").asInt() : 22;
> }

I did think of that, but decided against changing the config format in this change.

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1521#discussion_r1195640362