RFR: 1912: Show priority for bugs in pull request body [v2]

Zhao Song zsong at openjdk.org
Tue May 23 21:08:55 UTC 2023

On Tue, 23 May 2023 16:37:23 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> This is a big change that will likely take a few rounds of review before we get it right. I have made a first pass and left comments mostly about higher level structural issues.
> In addition to the below, I think it may be worth thinking about how we can minimize the amount of times we fetch the same issue from an IssueProject. Can we perhaps cache them in CheckWorkItem to avoid repeated fetching?

I think I have resolved most of the issues mentioned by you. And yes, it's possible for us to cache the issues, but I need more time to think about it, also, I think this patch is big enough. If you don't mind, I prefer to file a separate issue for this.

> bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestBot.java line 77:
>> 75:     private final boolean enableBackport;
>> 76:     private final Map<String, List<String>> issuePRMap;
>> 77:     private final Map<String, Boolean> initializedPRs = new ConcurrentHashMap<>();
> This could just be a `Set`. Also it doesn't need to be concurrent as it's local to just this PullRequestBot, and we don't run WorkItems for the same PR in parallel.

Ah, right! Thanks!


PR Comment: https://git.openjdk.org/skara/pull/1523#issuecomment-1560121276
PR Review Comment: https://git.openjdk.org/skara/pull/1523#discussion_r1202812618

More information about the skara-dev mailing list