RFR: 1912: Show priority for bugs in pull request body [v2]

Erik Joelsson erikj at openjdk.org
Tue May 23 23:03:24 UTC 2023

On Tue, 23 May 2023 22:41:11 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> Ah, right! Thanks!
> Think again about this, It's possible that CheckWorkItems for different PRs in the same repo run in parallel. Every CheckWorkItem is possible to modify `initializedPRs`. So we still need to synchronize it.

You are right, the map will be concurrently modified, just not the same element, and that requires a `ConcurrentHashMap` or synchronization to avoid corrupting data. I think `ConcurrentHashMap` is preferred here as I don't think there is a concurrent Set.


PR Review Comment: https://git.openjdk.org/skara/pull/1523#discussion_r1203124773

More information about the skara-dev mailing list