RFR: 2088: Skara /reviewers command is no longer effective

[Zhao Song]

On Thu, 2 Nov 2023 14:10:42 GMT, Erik Duveblad <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this fix for [SKARA-2088](https://bugs.openjdk.org/browse/SKARA-2088). The fix consists of adding a special value (`disable`) to the key `minimum` in the `[checks "reviewers"]` subsection. This way the functionality enabled by the `minimum` key can be disabled by `AdditionalConfiguration.java` (since INI doesn't feature a way for keys to be unset).
> 
> I also made the `ReviewersCheckConfiguration` a bit more strict - the `minimum` key should never be combined with the keys `lead`, `reviewers`, `committers`, `authors` or `contributors`.
> 
> Finally I added tests for the above three scenarios.
> 
> Thanks,
> Erik

Looks good

bots/pr/src/test/java/org/openjdk/skara/bots/pr/AdditionalConfigurationTests.java line 25:

> 23: package org.openjdk.skara.bots.pr;
> 24: 
> 25: import org.openjdk.skara.forge.*;

This import can be removed

-------------

Marked as reviewed by zsong (Reviewer).

PR Review: https://git.openjdk.org/skara/pull/1581#pullrequestreview-1710878398
PR Review Comment: https://git.openjdk.org/skara/pull/1581#discussion_r1380533194