Integrated: 2088: Skara /reviewers command is no longer effective

[Erik Duveblad]

On Thu, 2 Nov 2023 14:10:42 GMT, Erik Duveblad <ehelin at openjdk.org> wrote:

> Hi all,
> 
> please review this fix for [SKARA-2088](https://bugs.openjdk.org/browse/SKARA-2088). The fix consists of adding a special value (`disable`) to the key `minimum` in the `[checks "reviewers"]` subsection. This way the functionality enabled by the `minimum` key can be disabled by `AdditionalConfiguration.java` (since INI doesn't feature a way for keys to be unset).
> 
> I also made the `ReviewersCheckConfiguration` a bit more strict - the `minimum` key should never be combined with the keys `lead`, `reviewers`, `committers`, `authors` or `contributors`.
> 
> Finally I added tests for the above three scenarios.
> 
> Thanks,
> Erik

This pull request has now been integrated.

Changeset: 410d4e59
Author:    Erik Duveblad <ehelin at openjdk.org>
URL:       https://git.openjdk.org/skara/commit/410d4e59bdbebc3a7b3d394dc52a51fedb47ae57
Stats:     131 lines in 4 files changed: 108 ins; 2 del; 21 mod

2088: Skara /reviewers command is no longer effective

Reviewed-by: erikj, zsong

-------------

PR: https://git.openjdk.org/skara/pull/1581