RFR: 2082: Use correct .jcheck/conf in AdditionalConfiguration.java [v2]

Erik Duveblad ehelin at openjdk.org
Fri Nov 3 12:04:25 UTC 2023


> Hi all,
> 
> please review this patch that ensures that we pass the correct `.jcheck/conf` to [AdditionalConfiguration.java](https://github.com/openjdk/skara/blob/master/bots/pr/src/main/java/org/openjdk/skara/bots/pr/AdditionalConfiguration.java). The `.jcheck/conf` should either come from the "overriding" `.jcheck/conf` (if the PR bot is configured to use that) or the pull request's target branch.
> 
> I have added that test that passes with this patch but fails without it.
> 
> Thanks,
> Erik

Erik Duveblad has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:

 - final review
 - refactor
 - whitespace
 - do not throw from checkStatus
 - Merge branch 'master' into pr-correct-jcheck-conf
 - Fix .jcheck/conf parsing in multiple places
 - 2082

-------------

Changes:
  - all: https://git.openjdk.org/skara/pull/1578/files
  - new: https://git.openjdk.org/skara/pull/1578/files/2fdcc0dc..9a677529

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=skara&pr=1578&range=01
 - incr: https://webrevs.openjdk.org/?repo=skara&pr=1578&range=00-01

  Stats: 1381 lines in 43 files changed: 976 ins; 163 del; 242 mod
  Patch: https://git.openjdk.org/skara/pull/1578.diff
  Fetch: git fetch https://git.openjdk.org/skara.git pull/1578/head:pull/1578

PR: https://git.openjdk.org/skara/pull/1578


More information about the skara-dev mailing list