RFR: 2082: Use correct .jcheck/conf in AdditionalConfiguration.java [v3]

[Erik Duveblad]

On Fri, 27 Oct 2023 17:47:14 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java line 1274:
>> 
>>> 1272:                         pr.repository().forge().currentUser(), comments, reviewMerge);
>>> 1273:                 checkablePullRequest.executeChecks(localHash, censusInstance, visitor, additionalConfiguration, jcheckConfHash);
>>> 1274:                 // Don't need to run the second round if confOverride is set.
>> 
>> Strictly speaking, should we regenerate the AdditionalConfiguration for the second run where we use the merged .jcheck/conf?
>
> Oh, right, I overlooked it when I was implementing the second run of jcheck feature.

This has been re-worked in the latest version

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1578#discussion_r1381656132