RFR: 2082: Use correct .jcheck/conf in AdditionalConfiguration.java [v3]

[Zhao Song]

On Fri, 3 Nov 2023 14:17:25 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java line 1238:
>> 
>>> 1236:                         var commitJCheckConf = checkablePullRequest.parseJCheckConfiguration(hash)
>>> 1237:                                                 .orElseThrow(() -> new IllegalStateException("No .jcheck/conf present in tree for commit " + hash));
>>> 1238:                         var commitVisitor = checkablePullRequest.createVisitor(commitJCheckConf, hash);
>> 
>> We could move the creation of these two into the if block below. Could create `messageStream = targetVisitor.messages().stream()` before the if and override it with the concatenated stream inside the block. I think it's worth trying to minimize any external calls or processes when possible to speed up WorkItem processing.
>
> Maybe we shouldn't concat the streams and instead differentiate the message between the different jcheck runs and include information about which jcheck conf was used.

I agree with Erik here, it's better to include the jcheck conf information

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1578#discussion_r1382204131