RFR: 2101: Change confusing requirement text
Erik Joelsson
erikj at openjdk.org
Thu Nov 9 00:19:27 UTC 2023
On Wed, 8 Nov 2023 17:36:17 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
> The checkbox list in "Progress" in the PRs body says:
>
> "Commit message must refer to an issue"
>
> but it is not really talking about the commit message, but the PR title. The "refer to an issue" is also vague; especially since the only time you will be hit by this problem is when you are a newcomer, and do not understand what is expected of you.
>
> The text should be rephrased to be more helpful to newcomers.
If you run the command line jcheck and get this warning, the new message will look very confusing. The problem here is that we are running jcheck, which is it's own thing as part of validating a PR and posting the jcheck errors directly in the PR body. Even if running jcheck in a PR is more common than running the cmdline, I don't think just changing the message like this is a good idea.
-------------
PR Comment: https://git.openjdk.org/skara/pull/1584#issuecomment-1802964679
More information about the skara-dev
mailing list