RFR: 2089: Warn when bug fixVersion doesn't match .jcheck/conf version in PR [v2]

[Erik Joelsson]

On Thu, 9 Nov 2023 18:21:21 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> This patch tries to alert the user when the fixVersion in the issue differs from the fixVersion in .jcheck/conf, thereby preventing the creation of unwanted backports.
>
> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
> 
>   add fixVersionOverride option

bots/pr/src/main/java/org/openjdk/skara/bots/pr/PullRequestBotFactory.java line 247:

> 245:             }
> 246: 
> 247:             if (repo.value().contains("fixVersionOverride")) {

I think the config option should reflect that we are turning off this warning specifically, rather than that we have configured a different fixVersion in the notifier. There are more situations where this warning doesn't apply (see bug comments).

How about `versionMismatchWarning` and I think we should even default it to `false` and selectively add it to the repos we want it on.

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1585#discussion_r1388501264