RFR: 2084: Add a `/branch` command similar to `/tag` to create a new branch from a commit [v3]

Erik Joelsson erikj at openjdk.org
Mon Nov 13 13:45:34 UTC 2023


On Fri, 10 Nov 2023 08:43:27 GMT, Erik Duveblad <ehelin at openjdk.org> wrote:

>> Hi all,
>> 
>> please review this patch that adds a `/branch` commit command. The `/branch` commit command allows an integrator to create a _new_ branch in a repository by adding the comment `/branch <name>` on a commit's web page. The command will check that no branch with the given name exists (i.e. it won't update a branch with that name to that commit).
>> 
>> The implementation is very similar to the `/tag` command, but I don't think it makes sense to try to share code between them. They are both only around 60 lines of code, so trying to share code won't give us much.
>> 
>> I also added a couple of new unit tests.
>> 
>> Thanks,
>> Erik
>
> Erik Duveblad has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Use null free Optional pattern
>   
>   Co-authored-by: Erik Joelsson <37597443+erikj79 at users.noreply.github.com>

Marked as reviewed by erikj (Lead).

-------------

PR Review: https://git.openjdk.org/skara/pull/1583#pullrequestreview-1727346227


More information about the skara-dev mailing list