Integrated: 2016: CSRIssueBot shouldn't force CheckWorkItem to run

Zhao Song zsong at openjdk.org
Fri Nov 17 16:46:02 UTC 2023


On Wed, 15 Nov 2023 18:36:50 GMT, Zhao Song <zsong at openjdk.org> wrote:

> Currently, all the CheckWorkItems triggered by CSRIssueBot are having some privilege, these checkWorkItems could bypass the checksum check and force the update of the PR. Even when a user add a comment to the CSR issue, it will force the bot re-evaluate the  associated PR. This is bad and we don't have choice when implementing this.
> 
> Now we have introduced issuePRMap in SKARA-1912, so we could fix the above issue.  When creating the checkWorkItem in the CSRIssueWorkItem, we could look in the IssuePRmap. If the CSR issue is not associated with the pr, then we should force the update, otherwise we don't need to force the update.

This pull request has now been integrated.

Changeset: 42b9ee29
Author:    Zhao Song <zsong at openjdk.org>
URL:       https://git.openjdk.org/skara/commit/42b9ee295cdf5002972abd5990436ff148d2a4ff
Stats:     8 lines in 3 files changed: 4 ins; 1 del; 3 mod

2016: CSRIssueBot shouldn't force CheckWorkItem to run

Reviewed-by: erikj

-------------

PR: https://git.openjdk.org/skara/pull/1586


More information about the skara-dev mailing list