RFR: 2106: GitHub secondary rate limit causing delays for /backport command
Zhao Song
zsong at openjdk.org
Fri Nov 17 22:53:32 UTC 2023
On Fri, 17 Nov 2023 22:27:25 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
> We are hitting weird "secondary rate limit" problems when fetching branches for the fork repository in the BackportCommand. To try to alleviate this problem, I'm replacing that call to just fetch the single branch we actually want to find (instead of iterating through all to find it). This may not look like a big change, but the number of branches in some fork repos is now forcing 5+ pagination calls, so this single call should reduce the volume significantly. It's still unclear exactly why this particular call is triggering the rate limiter.
>
> The actual problem happens around line 262, but I figured I could apply the same thing on line 187 as well.
Looks good!
-------------
Marked as reviewed by zsong (Reviewer).
PR Review: https://git.openjdk.org/skara/pull/1587#pullrequestreview-1738060882
More information about the skara-dev
mailing list