RFR: 2082: Use correct .jcheck/conf in AdditionalConfiguration.java [v5]
Erik Duveblad
ehelin at openjdk.org
Thu Nov 30 19:34:32 UTC 2023
> Hi all,
>
> please review this patch that ensures that we pass the correct `.jcheck/conf` to [AdditionalConfiguration.java](https://github.com/openjdk/skara/blob/master/bots/pr/src/main/java/org/openjdk/skara/bots/pr/AdditionalConfiguration.java). The `.jcheck/conf` should either come from the "overriding" `.jcheck/conf` (if the PR bot is configured to use that) or the pull request's target branch.
>
> I have added that test that passes with this patch but fails without it.
>
> Thanks,
> Erik
Erik Duveblad has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 11 commits:
- Merge 'master'
- Reviewer feedback
- Merge master
- optimize
- final review
- refactor
- whitespace
- do not throw from checkStatus
- Merge branch 'master' into pr-correct-jcheck-conf
- Fix .jcheck/conf parsing in multiple places
- ... and 1 more: https://git.openjdk.org/skara/compare/a9727b65...f22f4878
-------------
Changes: https://git.openjdk.org/skara/pull/1578/files
Webrev: https://webrevs.openjdk.org/?repo=skara&pr=1578&range=04
Stats: 190 lines in 9 files changed: 110 ins; 4 del; 76 mod
Patch: https://git.openjdk.org/skara/pull/1578.diff
Fetch: git fetch https://git.openjdk.org/skara.git pull/1578/head:pull/1578
PR: https://git.openjdk.org/skara/pull/1578
More information about the skara-dev
mailing list