RFR: 2112: Update JDK to 21 and Gradle to 8.5 [v5]
Zhao Song
zsong at openjdk.org
Thu Nov 30 23:05:33 UTC 2023
On Thu, 30 Nov 2023 22:36:15 GMT, Erik Joelsson <erikj at openjdk.org> wrote:
>> Bumping JDK version to 21.0.1 and Gradle version to 8.4.
>>
>> There were two tests that needed to be updated. One was assuming iteration order on HashMap. The other was more complex as it was triggered by [JDK-8289689](https://bugs.openjdk.org/browse/JDK-8289689). My conclusion is that we can't count on unicode normalization returned from Git to match what the files in the filesystem have on mac, and so the test needs to accommodate for that. There is a longer explanation in a comment.
>
> Erik Joelsson has updated the pull request incrementally with one additional commit since the last revision:
>
> Update readme
Looks good
-------------
Marked as reviewed by zsong (Reviewer).
PR Review: https://git.openjdk.org/skara/pull/1590#pullrequestreview-1758639022
More information about the skara-dev
mailing list