RFR: 2049: After enabled maintainer approval in a repo, some pull requests are not updated [v2]

[Severin Gehwolf]

On Thu, 28 Sep 2023 18:51:20 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> Today, I enabled maintainer approval feature in openjdk/jdk8u-dev. 
>> 
>> After I enabled this feature, I expect to see the progress like "JDK-XXXXXXX needs maintainer approval" in the body of all open prs. 
>> 
>> However, this pr(https://github.com/openjdk/jdk8u-dev/pull/368) is not updated. 
>> 
>> The reason is that although after we enabled the maintainer approval feature, the issue labels will be calculated in the issueMetaData, there still exists some issues that doesn't contain any label. 
>> 
>> To solve this, I think we could add a string "approval" to issueMetaData after we enabled the maintainer approval.
>
> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckWorkItem.java
>   
>   Co-authored-by: Erik Joelsson <37597443+erikj79 at users.noreply.github.com>

bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckWorkItem.java line 217:

> 215:                         }
> 216:                         if (bot.approval() != null && bot.approval().needsApproval(pr.targetRef())) {
> 217:                             // Add a static sting to the metadata if the PR needs approval to force

Typo: `string` instead of `sting`?

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1563#discussion_r1343740419