Integrated: 2061: Checking for .jcheck/conf fails when pr/X branches are removed
Zhao Song
zsong at openjdk.org
Thu Oct 12 16:17:05 UTC 2023
On Thu, 12 Oct 2023 14:16:22 GMT, Zhao Song <zsong at openjdk.org> wrote:
> As Erik described in the issue, "The targetRefPRMap introduced in [SKARA-1937](https://bugs.openjdk.org/browse/SKARA-1937) isn't working well with the dependent PR feature. When a pr/X branch is removed, the map may still contains that branch which will cause getPeriodicItems to fail with exception when trying to get .jcheck/conf from the non existing branch.".
>
> To solve this issue, I think that every pr would only have one targetRef, so before the bot is trying to create an entry for the pr, the bot should delete any existing entry associated with that pr.
>
> Since the operations are all about HashMap, I believe they wouldn't significantly impact the bot's performance.
This pull request has now been integrated.
Changeset: 68e579f7
Author: Zhao Song <zsong at openjdk.org>
URL: https://git.openjdk.org/skara/commit/68e579f723cefb9042e5266caf47cb42dc95e3e5
Stats: 6 lines in 1 file changed: 6 ins; 0 del; 0 mod
2061: Checking for .jcheck/conf fails when pr/X branches are removed
Reviewed-by: erikj
-------------
PR: https://git.openjdk.org/skara/pull/1568
More information about the skara-dev
mailing list