RFR: 2063: Reduce the health check times of local repo instance [v3]

Zhao Song zsong at openjdk.org
Thu Oct 12 23:43:07 UTC 2023


On Thu, 12 Oct 2023 23:28:00 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   update
>
> bots/mlbridge/src/main/java/org/openjdk/skara/bots/mlbridge/WebrevStorage.java line 342:
> 
>> 340:                         jsonLocalStorage = hostedRepositoryPool.checkout(jsonStorage, storageRef, scratchPath);
>> 341:                     } catch (IOException e) {
>> 342:                         throw new RuntimeException(e);
> 
> This would throw `UncheckedIOException` before so should still do that. Can also consider just having one try-catch in the method, surrounding all of it, to avoid repeating the catch clause.

You are right, thanks for catching it!

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1569#discussion_r1357559329


More information about the skara-dev mailing list