Integrated: 2063: Reduce the health check times of local repo instance
Zhao Song
zsong at openjdk.org
Fri Oct 13 16:09:23 UTC 2023
On Thu, 12 Oct 2023 20:50:17 GMT, Zhao Song <zsong at openjdk.org> wrote:
> In the method HostedRepositoryPool#materializeClone, when the bot is trying to reuse a local repo instance, the bot will always check whether the repo is still good by processing command "git fsck --connectivity-only".
>
> Sometimes this command would be slow and Erik said that we should believe the bots are doing right things, so we should assume the local repos are good, so the health check is not always needed. But shutdown of the bot could make a local repo instance unhealthy, so we should at least do the health check once for each local repo instance after the bot is restarted.
>
> To solve this issue, Erik suggested to maintain a static map for keeping track of paths of known checked/good repositories.
>
> To leverage this patch to mlbridge bot, I also made some changes to WebrevStorage.
This pull request has now been integrated.
Changeset: b2abbc89
Author: Zhao Song <zsong at openjdk.org>
URL: https://git.openjdk.org/skara/commit/b2abbc896cf532420a90aebd2e5aaf8cae720738
Stats: 55 lines in 4 files changed: 41 ins; 5 del; 9 mod
2063: Reduce the health check times of local repo instance
Reviewed-by: erikj
-------------
PR: https://git.openjdk.org/skara/pull/1569
More information about the skara-dev
mailing list