RFR: 2064: Create jsonLocalStorage and htmlLocalStorage in separate directories
Zhao Song
zsong at openjdk.org
Fri Oct 13 19:46:48 UTC 2023
On Fri, 13 Oct 2023 18:20:30 GMT, Zhao Song <zsong at openjdk.org> wrote:
> In [SKARA-2063](https://bugs.openjdk.org/browse/SKARA-2063), I tried to let WebrevStorage to use HostedRepositoryPool, but I made a mistake. When the bot is trying to create a local clone, it will try to create jsonLocalStorage and htmlLocalStorage in the same directory. And previously, the bot will only create jsonLocalStorage when generateJson is true and create htmlLocalStorage when generateHtml is true. Now, the bot will create both clones when webrevGenerator#generate is called.
>
> To solve this problem, I think the bot should create jsonLocalStorage and htmlLocalStorage in separate directories and the bot should only create the local clone when it's necessary.
Thanks for the review!
-------------
PR Comment: https://git.openjdk.org/skara/pull/1570#issuecomment-1762116202
More information about the skara-dev
mailing list