RFR: 1962: JiraProject#queryIssues may return duplicate issues

[Erik Joelsson]

On Tue, 24 Oct 2023 22:49:43 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> issuetracker/src/main/java/org/openjdk/skara/issuetracker/jira/JiraProject.java line 510:
>> 
>>> 508: 
>>> 509:     private List<IssueTrackerIssue> queryIssues(String jql) {
>>> 510:         var ret = new HashMap<String, IssueTrackerIssue>();
>> 
>> I think we should try to preserve the order we received issues. We can do that if we use a `LinkedHashMap` here. It would also make more sense to me to use ascending order. Then we will include any concurrently updated issue in this call instead of waiting for next call. I also think it makes sense for the bot to process issues in ascending order, so the first updated issue is processed first.
>
> After offline discussion, I take this back, descending order is the correct solution. We could still preserve the order here, or maybe just sort the result on "updated" before returning it.

Or just skip sorting.

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1575#discussion_r1370903950