RFR: 1997: Allow the creator of a PR to set the commit author [v3]

Zhao Song zsong at openjdk.org
Fri Sep 1 20:34:39 UTC 2023


On Fri, 1 Sep 2023 17:06:07 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Zhao Song has updated the pull request incrementally with 10 additional commits since the last revision:
>> 
>>  - fix tests
>>  - update
>>  - Update bots/pr/src/main/java/org/openjdk/skara/bots/pr/AuthorCommand.java
>>    
>>    Co-authored-by: Erik Joelsson <37597443+erikj79 at users.noreply.github.com>
>>  - Update bots/pr/src/main/java/org/openjdk/skara/bots/pr/AuthorCommand.java
>>    
>>    Co-authored-by: Erik Joelsson <37597443+erikj79 at users.noreply.github.com>
>>  - Update bots/pr/src/main/java/org/openjdk/skara/bots/pr/AuthorCommand.java
>>    
>>    Co-authored-by: Erik Joelsson <37597443+erikj79 at users.noreply.github.com>
>>  - update
>>  - Update bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckablePullRequest.java
>>    
>>    Co-authored-by: Erik Joelsson <37597443+erikj79 at users.noreply.github.com>
>>  - Update bots/pr/src/main/java/org/openjdk/skara/bots/pr/AuthorCommand.java
>>    
>>    Co-authored-by: Erik Joelsson <37597443+erikj79 at users.noreply.github.com>
>>  - Update bots/pr/src/main/java/org/openjdk/skara/bots/pr/AuthorCommand.java
>>    
>>    Co-authored-by: Erik Joelsson <37597443+erikj79 at users.noreply.github.com>
>>  - Update bots/pr/src/main/java/org/openjdk/skara/bots/pr/AuthorCommand.java
>>    
>>    Co-authored-by: Erik Joelsson <37597443+erikj79 at users.noreply.github.com>
>
> bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckablePullRequest.java line 159:
> 
>> 157:     }
>> 158: 
>> 159:     Hash commit(Hash finalHead, Namespace namespace, String censusDomain, String sponsorId, Hash original, List<Comment> comments) throws IOException, CommitFailure {
> 
> Can you also replace the usage in `commitMessage` in this class.

Sure

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1553#discussion_r1313314717


More information about the skara-dev mailing list