RFR: 2015: Initial run of PR IssueBot misses issue updates

Zhao Song zsong at openjdk.org
Tue Sep 12 17:19:42 UTC 2023

On Tue, 12 Sep 2023 16:58:49 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Currently, if pullRequestBot is down for more than 10 minutes and during that time, if users make changes to some issues, than the update activities would not trigger CheckWorkItem after the bot restarts.
>> To solve this problem, In this patch, after the bot restarts, in the initial run, pullRequestBot would make CheckWorkItem compare both prMetaData and issueMetaData.
> bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckWorkItem.java line 232:
>> 230:                         }
>> 231:                     }
>> 232:                     // triggered by pr updates
> This comment should be moved out of the block.

Yes, will fix it


PR Review Comment: https://git.openjdk.org/skara/pull/1554#discussion_r1323345051

More information about the skara-dev mailing list