RFR: 827: Copyright year differences can be regarded as a clean backport [v2]

Zhao Song zsong at openjdk.org
Tue Sep 12 17:40:31 UTC 2023

On Tue, 12 Sep 2023 17:19:53 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

> I'm not sure about changing this code without having some kind of unit level testing for it. I'm quite surprised that we don't have any. I think we need to add basic coverage either before or with this change.
> You could extract some patches from real backported commits to use for these tests.

Sure, I didn't add some unit tests because I tested it with some real backport cases. And I agree with you, it's good to have some unit tests.


PR Comment: https://git.openjdk.org/skara/pull/1556#issuecomment-1716157347

More information about the skara-dev mailing list