RFR: 2015: Initial run of PR IssueBot misses issue updates [v2]

Erik Joelsson erikj at openjdk.org
Mon Sep 18 22:40:01 UTC 2023

On Wed, 13 Sep 2023 16:57:32 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> Currently, if pullRequestBot is down for more than 10 minutes and during that time, if users make changes to some issues, than the update activities would not trigger CheckWorkItem after the bot restarts.
>> To solve this problem, In this patch, after the bot restarts, in the initial run, pullRequestBot would make CheckWorkItem compare both prMetaData and issueMetaData.
> Zhao Song has updated the pull request incrementally with one additional commit since the last revision:
>   update

bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckWorkItem.java line 111:

> 109:      * Create Normal CheckWorkItem
> 110:      */
> 111:     public static CheckWorkItem normal(PullRequestBot bot, String prId, Consumer<RuntimeException> errorHandler, ZonedDateTime triggerUpdatedAt) {

Maybe call it `fromWorkItem`.


PR Review Comment: https://git.openjdk.org/skara/pull/1554#discussion_r1329349574

More information about the skara-dev mailing list