RFR: 827: Copyright year differences can be regarded as a clean backport [v3]

Zhao Song zsong at openjdk.org
Wed Sep 20 21:08:57 UTC 2023

On Wed, 20 Sep 2023 21:05:50 GMT, Erik Joelsson <erikj at openjdk.org> wrote:

>> Ah I get it now, this is a multiline pattern, not an either this line or that line. I thought you needed to tell something in the Java regex API that it was multiline, but maybe you don't if the pattern has a newline in it?
> I think this should work as is. The `Pattern.MULTILINE` and `Pattern.DOTALL` are used to change the meaning of `^`, `$` and `.` respectively to work differently with newlines. I don't think that's relevant for this pattern which contains an explicit newline. Sorry for the confusion!

I think having a newline in the pattern is enough, so we don't need to tell the java regex api that it is a multiline pattern.


PR Review Comment: https://git.openjdk.org/skara/pull/1556#discussion_r1332184795

More information about the skara-dev mailing list