RFR: 2037: Change the order of bots in PullRequestBotFactory

Erik Joelsson erikj at openjdk.org
Fri Sep 22 13:01:57 UTC 2023

On Thu, 21 Sep 2023 21:16:17 GMT, Zhao Song <zsong at openjdk.org> wrote:

> Today, when restarting the bot, I found that the IssueBot was down for a long time(about 30 minutes), and then I realized that in PullRequestBotFactory, we created all pullRequestBots first, then CSRIssueBots, and IssueBots last. 
> After the bot is restarted, the botRunner would run all pullRequestBots first and we have a lot of pullRequestBots, so it will take a lot of time. And if users make changes to issues in JBS during this interval, the IssueBot may not be able to get all updated issues. It's really bad. 
> To solve this problem, we could to reverse the order of bots in PullRequestBotFactory, therefore we could make sure IssueBot will be run firstly.

Marked as reviewed by erikj (Lead).

I approved too quickly. I think instead of reversing, we should preserve the order from the config file and just put *IssueBots first. We can collect them in separate lists and then compose the final list at the end of the factory.


PR Review: https://git.openjdk.org/skara/pull/1558#pullrequestreview-1639904335
Changes requested by erikj (Lead).

PR Review: https://git.openjdk.org/skara/pull/1558#pullrequestreview-1639907376

More information about the skara-dev mailing list