Integrated: 2038: Don't post error message of invalid jcheck configuration when encountering UncheckedIOException

Zhao Song zsong at openjdk.org
Fri Sep 22 21:33:51 UTC 2023


On Fri, 22 Sep 2023 18:30:04 GMT, Zhao Song <zsong at openjdk.org> wrote:

> In CheckWorkItem, the bot would check whether this pull request has a valid jcheck configuration and if not, the bot would post an error message of invalid jcheck configuration in the pull request. 
> 
> Today, a user reported that he saw this error message in his pull request and he couldn't determine whether the pull request is good. After reading the log, I found that it's just a temporary glitch. The bot was trying to read jcheck configuration in GitHub but got HttpTimeoutException, so the bot posted the error message. But it recovers in the next try. 
> https://github.com/openjdk/panama-foreign/pull/893 
> 
> To sum, in the cases of some temporary glitches, we shouldn't post error message to pull request to confuse users.

This pull request has now been integrated.

Changeset: f59da95a
Author:    Zhao Song <zsong at openjdk.org>
URL:       https://git.openjdk.org/skara/commit/f59da95aa040dd02edd363686bacd0d66b19a0d5
Stats:     2 lines in 1 file changed: 0 ins; 0 del; 2 mod

2038: Don't post error message of invalid jcheck configuration when encountering UncheckedIOException

Reviewed-by: erikj

-------------

PR: https://git.openjdk.org/skara/pull/1559


More information about the skara-dev mailing list