RFR: 2033: Require all bugs to be accessible before marking PR 'rfr'

Erik Joelsson erikj at openjdk.org
Mon Sep 25 20:27:02 UTC 2023

On Fri, 22 Sep 2023 22:00:41 GMT, Zhao Song <zsong at openjdk.org> wrote:

> If one or more issues associated with the pull request is not accessible, then the pull request should be considered as invalid. Also, no 'rft' label will be added to this pull request and this could help prevent emails from being sent out while the pull request is associated with invalid issues.

bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckRun.java line 415:

> 413:     private boolean updateReadyForReview(PullRequestCheckIssueVisitor visitor, List<String> additionalErrors) {
> 414:         // All the issues must be accessible
> 415:         if (!allIssuesAccessible) {

I would like to avoid having a boolean field that gets modified at some arbitrary point during a run. We can just send the `regularIssuesMap` to this method and we can check if any of the values is an empty Optional.


PR Review Comment: https://git.openjdk.org/skara/pull/1560#discussion_r1336352932

More information about the skara-dev mailing list