SKARA-2019 and dependent pull requests

[erik.joelsson at oracle.com]

Hello,

Dependent pull requests weren't considered with this feature. The way it 
works now, the approval logic won't be triggered until the PR targets a 
branch that is configured for approval. A quick and dirty workaround 
would be to configure 'pr/.*' as a set of branches that need approval 
for the repo. A more correct solution would be to implement proper 
support for pr/X branches by haing the bot extract the PR from the 
target branch name and follow that dependency chain until we find a non 
pr/X branch, and if that branch requires approval, activate the approval 
logic.

/Erik

On 9/27/23 09:44, Zhao Song wrote:
>
> Hi Goetz,
>
> Maybe it’s a bug in the maintainer approval feature.
>
> The skara bot would determine whether this pr needs maintainer 
> approval by checking whether merging into the target branch needs 
> maintainer approval.
>
> In this case, we only configured that merging into master branch of 
> jdk21u needs maintainer approval, however, for dependent pull 
> requests, the target branch is pr/XXX.
>
> I will try to fix it.
>
> Thank you,
>
> Zhao
>
> *From: *skara-dev <skara-dev-retn at openjdk.org> on behalf of 
> Lindenmaier, Goetz <goetz.lindenmaier at sap.com>
> *Date: *Wednesday, September 27, 2023 at 08:21
> *To: *skara-dev at openjdk.org <skara-dev at openjdk.org>, Erik Joelsson 
> <erik.joelsson at oracle.com>, Kevin Rushforth <kevin.rushforth at oracle.com>
> *Subject: *SKARA-2019 and dependent pull requests
>
> Hi Erik and Kevin,
>
> How does SKARA-2019/21 handle dependent pull requests?
>
> https://github.com/openjdk/jdk21u/pull/200
>
> The change is not marked for approval.
>
> Is this on purpose or just not yet implemented?
>
> If there is a needed follow up fix, I as a maintainer only approve the
>
> underlying change after approving the follow up to make
>
> sure they can both be pushed at the same time.
>
> So I would have expected the above PR to be marked
>
> as ready for approval.
>
> Best regards,
>
>   Goetz.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/skara-dev/attachments/20230927/9a79f74a/attachment-0001.htm>