RFR: 2045: Make maintainer approval feature compatible with dependent pr feature. [v2]

Zhao Song zsong at openjdk.org
Wed Sep 27 22:22:14 UTC 2023

> A user reported that a dependent pr in a repo which configured with maintainer approval feature is not marked for approval. 
> After investigation, I realized that the skara bot would determine whether this pr needs maintainer approval by checking whether merging into the target branch needs maintainer approval. 
> In this case, we only configured that merging into master branch of jdk21u needs maintainer approval, however, for dependent pull requests, the target branch is pr/XXX. 
> To fix this issue, we should let the skara bot be able to find the real target ref.

Zhao Song has updated the pull request incrementally with three additional commits since the last revision:

 - update
 - update
 - review comment


  - all: https://git.openjdk.org/skara/pull/1562/files
  - new: https://git.openjdk.org/skara/pull/1562/files/b0f7a491..cda5c577

 - full: https://webrevs.openjdk.org/?repo=skara&pr=1562&range=01
 - incr: https://webrevs.openjdk.org/?repo=skara&pr=1562&range=00-01

  Stats: 35 lines in 4 files changed: 15 ins; 16 del; 4 mod
  Patch: https://git.openjdk.org/skara/pull/1562.diff
  Fetch: git fetch https://git.openjdk.org/skara.git pull/1562/head:pull/1562

PR: https://git.openjdk.org/skara/pull/1562

More information about the skara-dev mailing list