RFR: 2049: After enabled maintainer approval in a repo, some pull requests are not updated [v2]

Zhao Song zsong at openjdk.org
Thu Sep 28 18:51:20 UTC 2023

> Today, I enabled maintainer approval feature in openjdk/jdk8u-dev. 
> After I enabled this feature, I expect to see the progress like "JDK-XXXXXXX needs maintainer approval" in the body of all open prs. 
> However, this pr(https://github.com/openjdk/jdk8u-dev/pull/368) is not updated. 
> The reason is that although after we enabled the maintainer approval feature, the issue labels will be calculated in the issueMetaData, there still exists some issues that doesn't contain any label. 
> To solve this, I think we could add a string "approval" to issueMetaData after we enabled the maintainer approval.

Zhao Song has updated the pull request incrementally with one additional commit since the last revision:

  Update bots/pr/src/main/java/org/openjdk/skara/bots/pr/CheckWorkItem.java
  Co-authored-by: Erik Joelsson <37597443+erikj79 at users.noreply.github.com>


  - all: https://git.openjdk.org/skara/pull/1563/files
  - new: https://git.openjdk.org/skara/pull/1563/files/39e68913..6694d79e

 - full: https://webrevs.openjdk.org/?repo=skara&pr=1563&range=01
 - incr: https://webrevs.openjdk.org/?repo=skara&pr=1563&range=00-01

  Stats: 2 lines in 1 file changed: 2 ins; 0 del; 0 mod
  Patch: https://git.openjdk.org/skara/pull/1563.diff
  Fetch: git fetch https://git.openjdk.org/skara.git pull/1563/head:pull/1563

PR: https://git.openjdk.org/skara/pull/1563

More information about the skara-dev mailing list