Integrated: 2049: After enabled maintainer approval in a repo, some pull requests are not updated

Zhao Song zsong at openjdk.org
Thu Sep 28 21:24:25 UTC 2023


On Thu, 28 Sep 2023 17:58:34 GMT, Zhao Song <zsong at openjdk.org> wrote:

> Today, I enabled maintainer approval feature in openjdk/jdk8u-dev. 
> 
> After I enabled this feature, I expect to see the progress like "JDK-XXXXXXX needs maintainer approval" in the body of all open prs. 
> 
> However, this pr(https://github.com/openjdk/jdk8u-dev/pull/368) is not updated. 
> 
> The reason is that although after we enabled the maintainer approval feature, the issue labels will be calculated in the issueMetaData, there still exists some issues that doesn't contain any label. 
> 
> To solve this, I think we could add a string "approval" to issueMetaData after we enabled the maintainer approval.

This pull request has now been integrated.

Changeset: be89a78a
Author:    Zhao Song <zsong at openjdk.org>
URL:       https://git.openjdk.org/skara/commit/be89a78a5ca9d5922021b67387894d7fd8a62fbb
Stats:     3 lines in 1 file changed: 3 ins; 0 del; 0 mod

2049: After enabled maintainer approval in a repo, some pull requests are not updated

Reviewed-by: erikj

-------------

PR: https://git.openjdk.org/skara/pull/1563


More information about the skara-dev mailing list