RFR: 2042: Allow bulk requests with /approval request command

[Erik Joelsson]

On Thu, 28 Sep 2023 23:07:06 GMT, Zhao Song <zsong at openjdk.org> wrote:

> As some users requested, we will allow bulk requests with `/approval` request command.
> 
> If an id is not specified in the `/approval` command, the bot will generate a maintainer approval request for all associated bugs.
> 
> This also applies to the `/approval cancel` command, which will cancel the maintainer approval request for all associated bugs.

bots/pr/src/main/java/org/openjdk/skara/bots/pr/ApprovalCommand.java line 89:

> 87:             var issueTrackerIssueOpt = issueProject.issue(issue.shortId());
> 88:             if (issueTrackerIssueOpt.isEmpty()) {
> 89:                 reply.println("Can not find " + issue.id() + " in the " + issueProject.name() + " project.");

The ID is already printed, so this error message doesn't need to include it. Maybe something like

Suggestion:

                reply.println("Can not be found in the " + issueProject.name() + " project.");

bots/pr/src/main/java/org/openjdk/skara/bots/pr/ApproveCommand.java line 120:

> 118:     }
> 119: 
> 120:     public static List<Issue> getIssues(String issueId, PullRequest pr, List<Comment> allComments, PrintWriter reply) {

This can be package private instead of public (don't set either `public` or `private`).

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1565#discussion_r1341335332
PR Review Comment: https://git.openjdk.org/skara/pull/1565#discussion_r1341330989