RFR: 2045: Make maintainer approval feature compatible with dependent pr feature. [v3]

Erik Joelsson erikj at openjdk.org
Fri Sep 29 19:00:13 UTC 2023

On Fri, 29 Sep 2023 18:47:15 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> A user reported that a dependent pr in a repo which configured with maintainer approval feature is not marked for approval. 
>> After investigation, I realized that the skara bot would determine whether this pr needs maintainer approval by checking whether merging into the target branch needs maintainer approval. 
>> In this case, we only configured that merging into master branch of jdk21u needs maintainer approval, however, for dependent pull requests, the target branch is pr/XXX. 
>> To fix this issue, we should let the skara bot be able to find the real target ref.
> Zhao Song has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains seven commits:
>  - Merge branch 'master' into SKARA-2045
>    # Conflicts:
>    #	bots/pr/src/main/java/org/openjdk/skara/bots/pr/ApprovalCommand.java
>  - update
>  - update
>  - review comment
>  - fix an issue
>  - add test
>  - SKARA-2045

Marked as reviewed by erikj (Lead).


PR Review: https://git.openjdk.org/skara/pull/1562#pullrequestreview-1651334112

More information about the skara-dev mailing list