Integrated: 2045: Make maintainer approval feature compatible with dependent pr feature.

Zhao Song zsong at openjdk.org
Fri Sep 29 19:16:26 UTC 2023


On Wed, 27 Sep 2023 19:50:25 GMT, Zhao Song <zsong at openjdk.org> wrote:

> A user reported that a dependent pr in a repo which configured with maintainer approval feature is not marked for approval. 
> 
> After investigation, I realized that the skara bot would determine whether this pr needs maintainer approval by checking whether merging into the target branch needs maintainer approval. 
>   
> In this case, we only configured that merging into master branch of jdk21u needs maintainer approval, however, for dependent pull requests, the target branch is pr/XXX. 
> 
> To fix this issue, we should let the skara bot be able to find the real target ref.

This pull request has now been integrated.

Changeset: ba26745a
Author:    Zhao Song <zsong at openjdk.org>
URL:       https://git.openjdk.org/skara/commit/ba26745a5e73aa6e15671d81704f53d5774299dd
Stats:     85 lines in 5 files changed: 75 ins; 1 del; 9 mod

2045: Make maintainer approval feature compatible with dependent pr feature.

Reviewed-by: erikj

-------------

PR: https://git.openjdk.org/skara/pull/1562


More information about the skara-dev mailing list