RFR: 2218: Automate execution of integration tests [v2]

[Erik Duveblad]

On Wed, 3 Apr 2024 17:25:17 GMT, Zhao Song <zsong at openjdk.org> wrote:

>> Erik Duveblad has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review feedback from Zhao
>
> forge/src/test/java/org/openjdk/skara/forge/github/GitHubIntegrationTests.java line 26:
> 
>> 24: 
>> 25: import java.time.Duration;
>> 26: import java.util.Properties;
> 
> No longer need "import java.util.Properties"

Thanks, fixed in latest!

> forge/src/test/java/org/openjdk/skara/forge/gitlab/GitLabIntegrationTests.java line 28:
> 
>> 26: import java.time.ZonedDateTime;
>> 27: import java.util.Arrays;
>> 28: import java.util.Properties;
> 
> No longer need "import java.util.Properties"

Thanks, fixed in latest!

> forge/src/test/java/org/openjdk/skara/forge/gitlab/GitLabIntegrationTests.java line 331:
> 
>> 329:     @Test
>> 330:     @EnabledIfTestProperties({"gitlab.user", "gitlab.pat", "gitlab.uri", "gitlab.group",
>> 331:                               "gitlab.user"})
> 
> "gitlab.user" is duplicated

Thanks, fixed in latest commit.

-------------

PR Review Comment: https://git.openjdk.org/skara/pull/1627#discussion_r1550288211
PR Review Comment: https://git.openjdk.org/skara/pull/1627#discussion_r1550287944
PR Review Comment: https://git.openjdk.org/skara/pull/1627#discussion_r1550287786